Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization for onboarding flow Ledger Live warning screen #532

Conversation

dhriaznov
Copy link
Contributor

@dhriaznov dhriaznov commented Jul 26, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

The Ledger Live warning screen added as part of this PR does not have the text added to the localization files:
#527

Issue Link: https://linear.app/xverseapp/issue/ENG-2484/add-localization-for-onboarding-flow-ledger-live-warning-screen
Context Link (if applicable):

🔄 Changes

🖼 Screenshot / 📹 Video

Monosnap Xverse Wallet 2023-07-26 19-22-03 Monosnap Xverse Wallet 2023-07-26 19-22-11 Monosnap Xverse Wallet 2023-07-26 19-22-22

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@dhriaznov dhriaznov self-assigned this Jul 26, 2023
@linear
Copy link

linear bot commented Jul 26, 2023

ENG-2484 Add localization for onboarding flow Ledger Live warning screen

The Ledger Live warning screen added as part of this PR does not have the text added to the localization files:

#527

yknl
yknl previously approved these changes Jul 27, 2023
@github-actions
Copy link

@yknl
Copy link
Contributor

yknl commented Jul 27, 2023

Tested

@yknl yknl merged commit 2615d17 into develop Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants